Guest OS rules#10098
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10098 +/- ##
============================================
- Coverage 18.08% 18.08% -0.01%
Complexity 16718 16718
============================================
Files 6037 6038 +1
Lines 542546 542667 +121
Branches 66431 66451 +20
============================================
+ Hits 98126 98144 +18
- Misses 433404 433504 +100
- Partials 11016 11019 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
BryanMLima
force-pushed
the
guest-os-rules
branch
from
4835d26 to
796ecb1
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13624 |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13720 |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13731 |
|
@BryanMLima can you look at the conflicts? |
I will take a look this week, apologies for disappearing 😅 . |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@BryanMLima Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch? |
|
Hi @BryanMLima is this PR ready? can you resolve the conflicts (and rebase with 4.22 if this can be targeted for 4.22.1). |
winterhazel
force-pushed
the
guest-os-rules
branch
from
ee9c893 to
fc78948
Compare
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17763 |
8 participants
Description
Currently, ACS provides a feature that enables a guest OS preference for a specific host, prioritizing VMs based on its OS. However, this functionality allows VMs with different OSes to be deployed in a host with a Guest OS defined, as expected as it is only a preference configuration; this is not always desired. For example, keeping proprietary OS in the same host could reduce licensing costs.
This PR tackles this scenario, allowing JavaScript rules, using the JS interpreter introduced in #5909, to direct VMs to specific hosts based on their OS. Different from the guest OS preference, these guest OS rules will be strict. This new feature added a new field,
Guest OS as JS rulein the host edit view to allow users the creation of these rules.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
In a local lab with two hosts (
host-1andhost-2) I created the guest OS rulevmGuestOs.toLowerCase().indexOf("debian") != -1forhost-2, and deployed multiple VMs using templates and ISOs.host-2was filtered during the deployment.host-2and verified that it was not possible.host-1tohost-2and vice versa.How did you try to break this feature and the system with this change?
I tried to deploy VMs in the same lab without the guest OS rules defined and validated that the deployment of VMs were being done as expected.